fix: add specific error message for duplicate SRP imports

Author: mathieuartu

app/components/Views/ImportNewSecretRecoveryPhrase/index.test.tsx

@@ -605,6 +605,49 @@ describe('ImportNewSecretRecoveryPhrase', () => {
       mockAlert.mockRestore();
     });
 
+    it('displays error when import fails with duplicate account', async () => {
+      const mockAlert = jest.spyOn(Alert, 'alert');
+      mockImportNewSecretRecoveryPhrase.mockRejectedValueOnce(
+        new Error(
+          'KeyringController - The account you are trying to import is a duplicate',
+        ),
+      );
+      mockGetString.mockResolvedValue(valid12WordMnemonic);
+
+      const { getByTestId, getByText } = renderScreen(
+        ImportNewSecretRecoveryPhrase,
+        { name: 'ImportNewSecretRecoveryPhrase' },
+        {
+          state: initialState,
+        },
+      );
+
+      const pasteButton = getByText(messages.import_from_seed.paste);
+
+      await act(async () => {
+        await fireEvent.press(pasteButton);
+      });
+
+      await waitFor(() => {
+        const importButton = getByTestId(ImportSRPIDs.IMPORT_BUTTON);
+        expect(importButton.props.disabled).toBe(false);
+      });
+
+      const importButton = getByTestId(ImportSRPIDs.IMPORT_BUTTON);
+
+      await act(async () => {
+        await fireEvent.press(importButton);
+      });
+
+      await waitFor(() => {
+        expect(mockAlert).toHaveBeenCalledWith(
+          messages.import_new_secret_recovery_phrase.error_duplicate_account,
+        );
+      });
+
+      mockAlert.mockRestore();
+    });
+
     it('displays generic error when import fails', async () => {
       const mockAlert = jest.spyOn(Alert, 'alert');
       mockImportNewSecretRecoveryPhrase.mockRejectedValueOnce(

app/components/Views/ImportNewSecretRecoveryPhrase/index.tsx

@@ -238,17 +238,24 @@ const ImportNewSecretRecoveryPhrase = () => {
 
       navigation.navigate('WalletView');
     } catch (e) {
-      if (
-        (e as Error)?.message === 'This mnemonic has already been imported.'
-      ) {
-        Alert.alert(
-          strings('import_new_secret_recovery_phrase.error_duplicate_srp'),
-        );
-      } else {
-        Alert.alert(
-          strings('import_new_secret_recovery_phrase.error_title'),
-          strings('import_new_secret_recovery_phrase.error_message'),
-        );
+      switch ((e as Error)?.message) {
+        case 'This mnemonic has already been imported.':
+          Alert.alert(
+            strings('import_new_secret_recovery_phrase.error_duplicate_srp'),
+          );
+          break;
+        case 'KeyringController - The account you are trying to import is a duplicate':
+          Alert.alert(
+            strings(
+              'import_new_secret_recovery_phrase.error_duplicate_account',
+            ),
+          );
+          break;
+        default:
+          Alert.alert(
+            strings('import_new_secret_recovery_phrase.error_title'),
+            strings('import_new_secret_recovery_phrase.error_message'),
+          );
       }
       setLoading(false);
     }

locales/languages/en.json

@@ -3834,6 +3834,7 @@
     "error_multiple_srp_word_error_3": " are incorrect or misspelled.",
     "error_invalid_srp": "Invalid Secret Recovery Phrase",
     "error_duplicate_srp": "This Secret Recovery Phrase has already been imported.",
+    "error_duplicate_account": "The account you are trying to import is a duplicate.",
     "invalid_qr_code_title": "Invalid QR Code",
     "invalid_qr_code_message": "The QR code does not contain a valid Secret Recovery Phrase",
     "success_1": "Wallet",