Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Warning when Rejecting an Approve tx Approval request with id XYZ not found #6860

Closed
seaona opened this issue Jul 21, 2023 · 1 comment · Fixed by #7077
Closed

[Bug] Warning when Rejecting an Approve tx Approval request with id XYZ not found #6860

seaona opened this issue Jul 21, 2023 · 1 comment · Fixed by #7077
Assignees
@vinistevam
Labels
release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented Jul 21, 2023

Describe the bug
Whenever we Reject an Approve transaction, we can see the following warning Approval request with id XYZ not found

Screenshots

approval-req-with-id.mp4

To Reproduce
Steps to reproduce the behavior

  1. Go to test dapp
  2. Deploy an ERC20 token
  3. Click Approve
  4. Reject the approval
  5. See warning

Expected behavior
Warning should be handled

Smartphone (please complete the following information):

  • Device: Pixel 6
  • OS: Android
  • App Version: main QA build a8d0613cc3d12ebea2f095bf29d68fe9d113f809

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@seaona seaona added type-bug Something isn't working team-confirmations-system DEPRECATED: please use "team-confirmations" label instead labels Jul 21, 2023
@seaona
Copy link
Contributor Author

seaona commented Jul 21, 2023

Note: this is a slightly different case than the one already fixed here

@anaamolnar anaamolnar added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Jul 26, 2023
@vinistevam vinistevam self-assigned this Aug 29, 2023
@vinistevam vinistevam mentioned this issue Aug 30, 2023
Merged
3 tasks
@metamaskbot metamaskbot added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinistevam vinistevam

Labels
release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Warning when rejecting an approval request with id XYZ not found MetaMask/metamask-mobile
4 participants
@metamaskbot @vinistevam @seaona @anaamolnar