Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add per session caching for ENS names #844

Closed
brunobar79 opened this issue Jul 18, 2019 · 1 comment · Fixed by #970
Closed

Add per session caching for ENS names #844

brunobar79 opened this issue Jul 18, 2019 · 1 comment · Fixed by #970
Labels
type-enhancement New feature or request v1
Milestone
v1

Comments

@brunobar79
Copy link
Contributor

Only for local accounts. If we do this with an external account we can end up sending funds to the wrong address!
@brunobar79 brunobar79 added type-enhancement New feature or request v1 labels Jul 18, 2019
@brunobar79 brunobar79 added this to the v1 milestone Jul 18, 2019
@brunobar79
Copy link
Contributor Author

Actually this is safe only if we do reverse-ens caching which is for display purposes only.

@brunobar79 brunobar79 mentioned this issue Jul 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement New feature or request v1
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

Reverse ENS caching MetaMask/metamask-mobile
1 participant
@brunobar79