Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to EIP-1193 provider changes #9037

Closed
9 tasks
mcmire opened this issue Mar 22, 2024 · 1 comment
Closed
9 tasks

Adapt to EIP-1193 provider changes #9037

mcmire opened this issue Mar 22, 2024 · 1 comment
Assignees

Comments

@mcmire
Copy link
Contributor

mcmire commented Mar 22, 2024

What is this about?

After SafeEventEmitterProvider is updated to support EIP-1193 and a new version of @metamask/eth-json-rpc-provider is released, we should adapt to the changes:

  • We should upgrade @metamask/network-controller, as that will incorporate the changes to @metamask/eth-json-rpc-provider.
  • At this point, calling sendAsync will be deprecated; we should use request instead.
    • We re-bind sendAsync in Engine.ts.
    • We also assume that the provider has a sendAsync method in AddressElement.test.tsx.

Scenario

(N/A)

Design

(N/A)

Technical Details

(Given above)

Threat Modeling Framework

(N/A)

Acceptance Criteria

(Given above)

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@desi
Copy link
Contributor

desi commented May 16, 2024

Maybe blocked controller upgrades at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants