You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should upgrade @metamask/network-controller, as that will incorporate the changes to @metamask/eth-json-rpc-provider.
At this point, calling sendAsync will be deprecated; we should use request instead.
We re-bind sendAsync in Engine.ts.
We also assume that the provider has a sendAsync method in AddressElement.test.tsx.
Scenario
(N/A)
Design
(N/A)
Technical Details
(Given above)
Threat Modeling Framework
(N/A)
Acceptance Criteria
(Given above)
Stakeholder review needed before the work gets merged
Engineering (needed in most cases)
Design
Product
QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
Security
Legal
Marketing
Management (please specify)
Other (please specify)
References
No response
The text was updated successfully, but these errors were encountered:
What is this about?
After
SafeEventEmitterProvider
is updated to support EIP-1193 and a new version of@metamask/eth-json-rpc-provider
is released, we should adapt to the changes:@metamask/network-controller
, as that will incorporate the changes to@metamask/eth-json-rpc-provider
.sendAsync
will be deprecated; we should userequest
instead.sendAsync
inEngine.ts
.sendAsync
method inAddressElement.test.tsx
.Scenario
(N/A)
Design
(N/A)
Technical Details
(Given above)
Threat Modeling Framework
(N/A)
Acceptance Criteria
(Given above)
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: