Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render specific confirmation screens #136

Closed
bitpshr opened this issue Sep 20, 2018 · 1 comment
Closed

Render specific confirmation screens #136

bitpshr opened this issue Sep 20, 2018 · 1 comment

Comments

@bitpshr
Copy link
Contributor

bitpshr commented Sep 20, 2018

We should detect the following types of eth_sendTransaction calls (based on their data field) and render specific styles of confirmation screens:

  • Detect contract deploy send
  • Detect token send
  • Detect contract function call send

Until we do this, all of these operations will still work from within a dapp since they're just eth_sendTransaction calls, but the user may not have a clear idea what's going on.

@brunobar79
Copy link
Contributor

Fixed via #276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants