Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Install MetaMask Extension" doesn't work with two wallets that inject window.ethereum #1131

Open
tiagofilipenunes opened this issue Nov 15, 2024 · 1 comment

Comments

@tiagofilipenunes
Copy link

tiagofilipenunes commented Nov 15, 2024

SDK

Web

Provide environment information

MacOS 15.0.1
Chrome 131.0.6778.69

MetaMask SDK Version

0.30.1

MetaMask Mobile app Version

N/A

What browser are you using? (if relevant)

Chrome 131.0.6778.69

How are you deploying your application? (if relevant)

No response

Describe the Bug

With two wallets that use the window.ethereum namespace installed, such as Trust Wallet and Rabby Wallet, the button in the wallet connect pop-up to "Install MetaMask Extension" doesn't work.

Expected Behavior

To be redirected to the metamask install page even with other wallets installed that use the window.ethereum namespace installed.

Link to reproduction - Issues with a link to complete (but minimal) reproduction code will be addressed faster

https://stackblitz.com/edit/new-wagmi-pddqi8

To Reproduce

  1. Manually initialize the MetaMask connector using wagmi (other ways should also see this bug as it is related to using the SDK pop-up)
  2. Have 2 other wallets that use the window.ethereum namespace (common). For example, Trust Wallet and Rabby Wallet
  3. If MetaMask is not found, there is an SDK pop-up window that shows a button to "Install MetaMask Extension"
  4. Press the button, nothing happens and this error comes up:
Uncaught (in promise) TypeError: Cannot delete property 'ethereum' of #<Window>
    at metamask-sdk-RGE6HBAI.js?v=f475bd21:20131:95
    at Generator.next (<anonymous>)
    at metamask-sdk-RGE6HBAI.js?v=f475bd21:15299:44
    at new Promise (<anonymous>)
    at kk (metamask-sdk-RGE6HBAI.js?v=f475bd21:15277:16)
    at metamask-sdk-RGE6HBAI.js?v=f475bd21:20130:20
    at startDesktopOnboarding (metamask-sdk-RGE6HBAI.js?v=f475bd21:20133:12)
    at HTMLUnknownElement.v3 (metamask-sdk-RGE6HBAI.js?v=f475bd21:27262:37)
    at Object.Ar2 (metamask-sdk-RGE6HBAI.js?v=f475bd21:27272:130)
    at Dr2 (metamask-sdk-RGE6HBAI.js?v=f475bd21:27279:42)
@ibwei
Copy link

ibwei commented Nov 25, 2024

any updates?

@tiagofilipenunes tiagofilipenunes changed the title [Bug]: TypeError: Cannot delete property 'ethereum' of #<Window> [BUG] "Install MetaMask Extension" doesn't work with two wallets that inject window.ethereum Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants