Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhance sdk copy script cleanup for improved build consistency #1137

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

abretonc7s
Copy link
Collaborator

@abretonc7s abretonc7s commented Nov 20, 2024

Overview

This PR enhances the SDK copy script by including the sdk-install-modal-web distribution directory in the cleanup process, ensuring a completely clean state before copying new files. The change also adds Vite cache cleanup for better build consistency.

Included the sdk-install-modal-web dist directory in the removal process to ensure a clean state before copying new files.
@abretonc7s abretonc7s changed the title chore: add removal of sdk-install-modal-web dist directory Included the sdk-install-modal-web dist directory in the removal process to ensure a clean state before copying new files. chore: enhance sdk copy script cleanup for improved build consistency Nov 20, 2024
@abretonc7s abretonc7s marked this pull request as ready for review November 20, 2024 11:59
@abretonc7s abretonc7s requested a review from a team as a code owner November 20, 2024 11:59
@abretonc7s abretonc7s enabled auto-merge (squash) November 20, 2024 12:00
Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s merged commit 2e79347 into main Nov 20, 2024
8 checks passed
@abretonc7s abretonc7s deleted the copy-web branch November 20, 2024 12:02
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.91%. Comparing base (dbc1cc1) to head (db18448).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1137   +/-   ##
=======================================
  Coverage   76.91%   76.91%           
=======================================
  Files         181      181           
  Lines        4241     4241           
  Branches     1042     1042           
=======================================
  Hits         3262     3262           
  Misses        979      979           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

sonarcloud bot commented Nov 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants