wip: fix test after readable-stream upgrade

Author: legobeat

test/index.js

@@ -1,5 +1,5 @@
-const test = require('tape');
 const { PassThrough, Transform, finished, pipeline } = require('readable-stream');
+const test = require('tape');
 // eslint-disable-next-line import/no-unresolved
 const ObjMultiplex = require('../dist');
 
@@ -18,7 +18,7 @@ test('basic - string', (t) => {
   inStream.write('wuurl');
 
   // simulate disconnect
-  setTimeout(() => inTransport.destroy());
+  setImmediate(() => inTransport.end(null, () => {}));
 });
 
 test('basic - obj', (t) => {
@@ -39,7 +39,7 @@ test('basic - obj', (t) => {
   inStream.write({ message: 'wuurl' });
 
   // simulate disconnect
-  setTimeout(() => inTransport.destroy());
+  setImmediate(() => inTransport.end(null, () => {}));
 });
 
 test('roundtrip', (t) => {
@@ -54,7 +54,7 @@ test('roundtrip', (t) => {
     },
   });
 
-  pipeline(outStream, doubler, outStream);
+  pipeline(outStream, doubler, outStream, () => {});
 
   bufferToEnd(inStream, (err, results) => {
     t.error(err, 'should not error');
@@ -66,7 +66,7 @@ test('roundtrip', (t) => {
   inStream.write(12);
 
   // simulate disconnect
-  setTimeout(() => outTransport.destroy(), 100);
+  setTimeout(() => outTransport.end(), 100);
 });
 
 test('error on createStream if destroyed', (t) => {
@@ -104,7 +104,7 @@ function basicTestSetup() {
   const inStream = inMux.createStream('hello');
   const outStream = outMux.createStream('hello');
 
-  pipeline(inMux, inTransport, outMux, outTransport, inMux);
+  pipeline(inMux, inTransport, outMux, outTransport, inMux, () => {});
 
   return {
     inTransport,
@@ -118,6 +118,20 @@ function basicTestSetup() {
 
 function bufferToEnd(stream, callback) {
   const results = [];
-  finished(stream, (err) => callback(err, results));
-  stream.on('data', (chunk) => results.push(chunk));
+  let flushed = false;
+  function onFinish(err) {
+    if (flushed) {
+      return;
+    }
+    flushed = true;
+    return callback(err, results);
+  }
+  stream.prependListener('abort', onFinish);
+  stream.prependListener('close', onFinish);
+  stream.prependListener('error', onFinish);
+  stream.prependListener('finish', onFinish);
+  finished(stream, onFinish);
+  stream.on('data', (chunk) => {
+    results.push(chunk);
+  });
 }

yarn.lock

@@ -338,7 +338,7 @@ ansi-colors@^4.1.1:
   resolved "https://registry.yarnpkg.com/ansi-colors/-/ansi-colors-4.1.1.tgz#cbb9ae256bf750af1eab344f229aa27fe94ba348"
   integrity sha512-JoX0apGbHaUJBNl6yF+p6JAFYZ666/hhCGKN5t9QFjbJQKUU/g8MNbFDbvfrgKXvI1QpZplPOnwIo99lX/AAmA==
 
-ansi-regex@^5.0.0, ansi-regex@^5.0.1:
+ansi-regex@^5.0.1:
   version "5.0.1"
   resolved "https://registry.yarnpkg.com/ansi-regex/-/ansi-regex-5.0.1.tgz#082cb2c89c9fe8659a311a53bd6a4dc5301db304"
   integrity sha512-quJQXlTSUGL2LH9SUXo8VwsY4soanhgo6LNSm84E1LBcE8s3O0wpdiRzyR9z/ZZJMlMWv37qOOb9pdJlMUEKFQ==