Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to phishing warning page #38

Open
3 tasks
holantonela opened this issue Oct 4, 2022 · 5 comments
Open
3 tasks

Add metrics to phishing warning page #38

holantonela opened this issue Oct 4, 2022 · 5 comments

Comments

@holantonela
Copy link

holantonela commented Oct 4, 2022

Background

We are iterating the current version of the phishing warning page. Ideally, we improve how we communicate the risk to users, so they decide NOT to move forward visiting the deceptive site.

Before iterating, we should implement some metrics to have a baseline for the current usage and be able to measure if the new version is indeed effective or not.

Acceptance Criteria

  1. Phishing warning page event is triggered when users who have opted in MetaMetrics are prompted to it.
  2. Phishing warning page link(s) event is triggered when users who have opted in MetaMetrics click on:
    2.1 Main CTA [Back to safety]
    2.2 Continue to the suspicious site [Continue to the site]
    2.3 External link to report an error in the flagging
    2.4 External link to Zendesk [Learn More]
    2.5 External link for lists providers

Metrics Checklist

@holantonela holantonela changed the title Add event tracking for the phishing warning page Add event tracking Oct 4, 2022
@holantonela holantonela changed the title Add event tracking Add metrics to phishing warning page Oct 4, 2022
@worldlyjohn
Copy link

All external links should trigger an event name External Link Clicked with the following properties:

  • link_type: Phishing Detection
  • url_domain or url: if url may be sensitive, like a token tracker, then only store domain and use url_domain. if url is a generic/common page then full url is ok and use url.
  • location: page where exists
  • chain_id: chain id in hex
  • category: Navigation

For the page event, we want to confirm that we are sending the url of the offending site

@bschorchit
Copy link

All external links should trigger an event name External Link Clicked with the following properties:

  • link_type: Phishing Detection
  • url_domain or url: if url may be sensitive, like a token tracker, then only store domain and use url_domain. if url is a generic/common page then full url is ok and use url.
  • location: page where exists
  • chain_id: chain id in hex
  • category: Navigation

For the page event, we want to confirm that we are sending the url of the offending site

Hey @worldlyjohn , I'm grooming this to work on these new metrics with PS team and I have couple of comments/questions here:

  • link_type: Phishing Detection - Should we use snake case here? phishing_detection instead of Phishing Detection for the value.

  • location: page where exists - for this case, will this info be repetitive with the link_type one? Because it will also refer to phishing detection/ phishing warning page. But I understand we might want to keep both to have the same properties as other External Link Clicked have.

  • chain_id: chain id in hex - Is chain_id information really useful here? The user is trying to open a new dapp when this page gets displayed it doesn't mean their MM is already reflecting the chain that that dapp uses.

For reference, I'm grooming this here.

@bschorchit
Copy link

bschorchit commented Nov 21, 2022

link_type: Phishing Detection - Should we use snake case here? phishing_detection instead of Phishing Detection for the value.

Update: I proposed this to be the possible values (see below), happy to iterate on the exact naming.
link_type: learn_more | report_wrong_detection | continue_to_site | back_to_safety

I do see on Mixpanel that the other External Link Clicked are not using snake case, any reason for that?

@bschorchit
Copy link

Any recommendations of name or properties for the event that will be fired when we the phishing warning page gets displayed? Already added the url property.

@worldlyjohn
Copy link

worldlyjohn commented Dec 5, 2022

@bschorchit

  • link_type: yes on snake case. this event should use a single property value for link_type. other link types might be "customer_support" or "block_explorer".
  • location: yes it can be repetitive. the purpose was for something like "contact support". we might want to know what page they are finding this from (home vs a secondary page)
  • chain_id: not necessary as you suggest.

link_type: learn_more | report_wrong_detection | continue_to_site | back_to_safety

i'm not sure this is at the right level, but rather secondary descriptors of the link_type=Phishing Detection, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants