Skip to content
This repository has been archived by the owner on Jan 3, 2022. It is now read-only.

Standardize error codes #18

Closed
rekmarks opened this issue May 28, 2019 · 2 comments
Closed

Standardize error codes #18

rekmarks opened this issue May 28, 2019 · 2 comments
Assignees
@rekmarks
Labels
enhancement New feature or request standardization Make something comply with a standard
Milestone
MVP Phase 1

Comments

@rekmarks
Copy link
Member

rekmarks commented May 28, 2019 •
edited
Loading

RPC error codes need standardization. See e.g. here.

Possible standards to adopt include EIP 1193, although we'd probably extend their error codes beyond their intended use. See https://eips.ethereum.org/EIPS/eip-1193, "Error object and codes".

We will attempt to add additional error codes and/or modify the error codes on EIP 1193. Working with one of the authors to accomplish this.
@rekmarks rekmarks added this to the MVP Phase 1 milestone Jul 31, 2019
@rekmarks rekmarks added standardization Make something comply with a standard and removed mvp-phase-1 labels Jul 31, 2019
@rekmarks rekmarks self-assigned this Jul 31, 2019
@rekmarks rekmarks added the help wanted Extra attention is needed label Jul 31, 2019
@danfinlay
Copy link
Contributor

Deserves an EIP! Thanks for making an issue from the todo.

@rekmarks rekmarks removed the help wanted Extra attention is needed label Aug 5, 2019
@rekmarks rekmarks added the enhancement New feature or request label Aug 14, 2019
@rekmarks
Copy link
Member Author

Updated EIP 1193: ethereum/EIPs#2240

Incorporated in: https://www.npmjs.com/package/eth-json-rpc-errors

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rekmarks rekmarks

Labels
enhancement New feature or request standardization Make something comply with a standard
Projects
None yet
Milestone
MVP Phase 1
Development

No branches or pull requests
2 participants
@danfinlay @rekmarks