Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache decrypted state to improve performance #2951

Open
Mrtenz opened this issue Dec 11, 2024 · 3 comments
Open

Cache decrypted state to improve performance #2951

Mrtenz opened this issue Dec 11, 2024 · 3 comments
Assignees
@Mrtenz

Comments

@Mrtenz
Copy link
Member

Mrtenz commented Dec 11, 2024

Snap state (managed through snap_manageState) can be cached in memory to improve performance, and avoid decrypting multiple times.
@Mrtenz Mrtenz self-assigned this Dec 11, 2024
@FrederikBolding
Copy link
Member

@Mrtenz We should wipe the cached state when the client is locked, similarly to KeyringController

@FrederikBolding
Copy link
Member

Also worth it to loop in @naugtur to potentially with exploring some obfuscation techniques

@naugtur
Copy link

naugtur commented Dec 16, 2024

How critical is the data that's getting cached?
What's the size of that data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mrtenz Mrtenz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@naugtur @FrederikBolding @Mrtenz