Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket has become much less useful due to teardown #846

Closed
FrederikBolding opened this issue Oct 13, 2022 · 4 comments · Fixed by #1122
Closed

WebSocket has become much less useful due to teardown #846

FrederikBolding opened this issue Oct 13, 2022 · 4 comments · Fixed by #1122
Assignees
@FrederikBolding
Labels
area-capabilities Related to the kinds of things that snaps are able to do.

Comments

@FrederikBolding
Copy link
Member

How do we expect snap devs to leverage WebSockets now that we tear it down after each RPC request has finished processing?

Technically you could use long-running and a never resolving promise, but we shouldn't encourage that.

Do we need to add a permission along the lines of "trigger a snap RPC method when a message is received from x"? (similar to cronjobs)
@FrederikBolding FrederikBolding added the area-capabilities Related to the kinds of things that snaps are able to do. label Oct 13, 2022
@FrederikBolding
Copy link
Member Author

FrederikBolding commented Oct 13, 2022 •
edited
Loading

cc @ritave @rekmarks

@FrederikBolding FrederikBolding mentioned this issue Oct 25, 2022
Open
@ritave
Copy link
Contributor

ritave commented Jan 5, 2023

Let's remove WebSockets for now and re-add them after we figure out how to approach #945

@FrederikBolding FrederikBolding mentioned this issue Jan 12, 2023
Merged
@FrederikBolding FrederikBolding self-assigned this Jan 12, 2023
@dawsbot
Copy link

dawsbot commented Feb 22, 2023

Hi folks, I just submitted #1232 to start using WebSockets in snaps. Does this mean that it is not possible currently?

@ritave
Copy link
Contributor

ritave commented Feb 28, 2023

Hey @dawsbot sadly, not for v1. We want to re-add support for websockets soon after, but for now we just don't have the manpower to get them working as good as we would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrederikBolding FrederikBolding

Labels
area-capabilities Related to the kinds of things that snaps are able to do.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING: Remove WebSocket MetaMask/snaps
3 participants
@FrederikBolding @ritave @dawsbot