Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Various EIP-712 TypedSign buttons (V1) - part 1 (Blur - Order, PermitBatch, PermitSingle, Seaport - BulkOrder) #358

Open
4 of 7 tasks
digiwand opened this issue Sep 20, 2024 · 2 comments · May be fixed by #376
Open
4 of 7 tasks

Add Various EIP-712 TypedSign buttons (V1) - part 1 (Blur - Order, PermitBatch, PermitSingle, Seaport - BulkOrder) #358

digiwand opened this issue Sep 20, 2024 · 2 comments · May be fixed by #376

Comments

@digiwand
Copy link
Contributor

digiwand commented Sep 20, 2024 •
edited
Loading

There are various TypedSign structs requested.

PR: #376

  • PermitSingle - Uniswap
  • PermitBatch - Uniswap
  • BulkOrder (Seaport. Seaport OrderComponents exists)
  • Order (example)

See Part 2 issue: #377

  • Vote
  • Permit - Dai
  • PermitWitnessTransferFrom - Uniswap Permit2
@digiwand digiwand self-assigned this Sep 20, 2024
@bschorchit
Copy link

I think we can skip Root since it's only a hex and we won't be able to decode it.
Screenshot 2024-09-23 at 17 56 38

@digiwand
Copy link
Contributor Author

👍🏼 removed Root spec. Thank you @bschorchit!

@digiwand digiwand removed their assignment Nov 27, 2024
@digiwand digiwand changed the title Add Various EIP-712 TypedSign buttons (V1) Add Various EIP-712 TypedSign buttons (V1) - part 1 Nov 27, 2024
@digiwand digiwand linked a pull request Nov 27, 2024 that will close this issue
Open
@digiwand digiwand changed the title Add Various EIP-712 TypedSign buttons (V1) - part 1 Add Various EIP-712 TypedSign buttons (V1) - part 1 (Blur - Order, PermitBatch, PermitSingle, Seaport - BulkOrder) Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@digiwand @bschorchit