Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Endpoint Discussion #143

Open
Hetti opened this issue Dec 1, 2022 · 0 comments
Open

API Endpoint Discussion #143

Hetti opened this issue Dec 1, 2022 · 0 comments

Comments

@Hetti
Copy link
Member

Hetti commented Dec 1, 2022

  • Instead of sending a free-format "date", it would be cleaner to send back "startDate" and "endDate" in isoformat, and let the frontend decide how to render that.
  • The number of events to fetch should maybe be a GET parameter instead of being hardcoded to 5.
  • We should make an effort to keep names of things consistent between FE, API and BE where fields correspond to one another. Here that would mean renaming "subtitle" to "teaser" (and keeping the camel case for the date fields specified above).

All of this applies in particular if this isn't a one-off and we wanna start building an API. Also, I'm gonna do this in vanilla Django for now, but if we wanna do that, we should think about maybe using something like DRF.

Originally posted by @ralokt in #141 (comment)

@MaxValue MaxValue pinned this issue Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant