Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsAppUrl filter & curl #8

Open
soolidtech opened this issue Jun 2, 2022 · 1 comment
Open

IsAppUrl filter & curl #8

soolidtech opened this issue Jun 2, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@soolidtech
Copy link

meteor-fast-render/lib/server/utils.js

Line 29 in 0a3e50c

return /html/.test(req.headers.accept);

IsAppUrl makes SSR feature impossible with crawlers like curl which have accept header fixed to */* (all)

Maybe it should be replaced by :

return /html|\*\/\*/.test(req.headers.accept);
@soolidtech
Copy link
Author

for reference : https://developer.mozilla.org/fr/docs/Web/HTTP/Headers/Accept

@StorytellerCZ StorytellerCZ added enhancement New feature or request good first issue Good for newcomers labels Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StorytellerCZ @soolidtech