Correct BlockUtils#isValidMobSpawn (#4367)

RacoonDog · web-flow · commit 9bc0cabb3d67 · 2024-01-30T18:56:49.000Z
diff --git a/src/main/java/meteordevelopment/meteorclient/utils/world/BlockUtils.java b/src/main/java/meteordevelopment/meteorclient/utils/world/BlockUtils.java
@@ -260,10 +260,10 @@ public static MobSpawn isValidMobSpawn(BlockPos blockPos, BlockState blockState,
             if (downState.isTransparent(mc.world, down)) return MobSpawn.Never;
         }
 
-        if (mc.world.getLightLevel(blockPos, 0) <= spawnLightLimit) return MobSpawn.Potential;
-        else if (mc.world.getLightLevel(LightType.BLOCK, blockPos) <= spawnLightLimit) return MobSpawn.Always;
+        if (mc.world.getLightLevel(LightType.BLOCK, blockPos) > spawnLightLimit) return MobSpawn.Never;
+        else if (mc.world.getLightLevel(LightType.SKY, blockPos) > spawnLightLimit) return  MobSpawn.Potential;
 
-        return MobSpawn.Never;
+        return MobSpawn.Always;
     }
 
     public static boolean topSurface(BlockState blockState) {

Original file line number	Diff line number	Diff line change
`@@ -260,10 +260,10 @@ public static MobSpawn isValidMobSpawn(BlockPos blockPos, BlockState blockState,`
`260`	`260`	`if (downState.isTransparent(mc.world, down)) return MobSpawn.Never;`
`261`	`261`	`}`
`262`	`262`
`263`		`- if (mc.world.getLightLevel(blockPos, 0) <= spawnLightLimit) return MobSpawn.Potential;`
`264`		`- else if (mc.world.getLightLevel(LightType.BLOCK, blockPos) <= spawnLightLimit) return MobSpawn.Always;`
	`263`	`+ if (mc.world.getLightLevel(LightType.BLOCK, blockPos) > spawnLightLimit) return MobSpawn.Never;`
	`264`	`+ else if (mc.world.getLightLevel(LightType.SKY, blockPos) > spawnLightLimit) return MobSpawn.Potential;`
`265`	`265`
`266`		`- return MobSpawn.Never;`
	`266`	`+ return MobSpawn.Always;`
`267`	`267`	`}`
`268`	`268`
`269`	`269`	`public static boolean topSurface(BlockState blockState) {`