Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is.js #19

Open
xumx opened this issue Apr 16, 2015 · 7 comments
Open

is.js #19

xumx opened this issue Apr 16, 2015 · 7 comments

Comments

@xumx
Copy link

xumx commented Apr 16, 2015

I would like to try integrating this library. Please fork.

https://github.com/arasatasaygin/is.js/

@splendido
Copy link
Member

Hello @xumx!
I've just forked the repo and added you to the isjs team

To proceed you can try to follow the wiki to get an official integration, or try with the new sister repo approach me and @dandv are trying to investigate.

@splendido
Copy link
Member

There's already an isjs organization on Atmosphere...
...was it you @dandv?

@splendido
Copy link
Member

...wooops, I've just discoverd I'm already a member of isjs and @xumx is too!
So I guess it was defenitely @dandv ;-)

@xumx
Copy link
Author

xumx commented Apr 23, 2015

I created that atmosphere organization.
I followed the wiki and the packaging is successful. published at https://atmospherejs.com/isjs/is

Not sure how to get autopublish.meteor.com to work though. I logged in with my github account and there is nothing. No repository to work with.

@splendido
Copy link
Member

Ok, so it wasn't @dandv ;-)

...It's the original author that is supposed to turn on autopublish.meteor.com to get automated publishes, but this can't happen before he merges a PR to get real official integration

@splendido
Copy link
Member

The only thing I'm concerned about is that the forked repo expects the author to publish the package from his machine: see here

This is not what we were originally saying in the step by step guide at points 8 and 9...
There must have been some mistakes putting in a wrong link.
I'm sorry for this.

I've just updated point 9.

@splendido
Copy link
Member

But there's no task within the Gruntfile to update the version number...
...so my guess is it's done by hands. :(

Lets have a look here to get an example of a task to update version numbers.

What about proposing this to the author?
...after manual update of version number inside package.json all other files (bower.json, package.js, etc.) will be updated automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants