Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserStory] Dealing with an image larger than the window #124

Open
5 tasks done
CamiJolly1 opened this issue Oct 31, 2023 · 7 comments
Open
5 tasks done

[UserStory] Dealing with an image larger than the window #124

CamiJolly1 opened this issue Oct 31, 2023 · 7 comments
Assignees
Labels
E: 3 Effort: 3 Story-Points enhancement New feature or request S: Significant Severity: Significant - in the mainline plan user story User Story

Comments

@CamiJolly1
Copy link
Contributor

CamiJolly1 commented Oct 31, 2023

User Story

Essential components

  • Title describes the story
  • Stakeholder type is identified
  • Outcome is described
  • Rationale is explicit
  • Acceptance criteria are verifiable and from the perspective of the stakeholder

Story

As a user
I want to understand ImageLab's behavior when the picture is larger than the window
so that the I am not confused by the behavior of the product

Acceptance Criteria

  • The user receives notifications from the product about the effect of opening an image whose dimensions exceed the maximum window size for their display.

Supporting Information

Current behavior

When the image dimensions are smaller than the window, the window displays the entire image, whereas adding an image that doesn't fit within the window's bounds does not allow the user to see the entire image. When inserting an image into ImageLab and the image dimensions are larger than the window, only the topmost left corner is shown. The image is cut off and there is no way to move the window to look at the other parts of the image, such as adding a scroll bar, shrinking the image, or not even allowing the image to appear in the first place.
This issue correlates with [UserStory] Getting an image to scale to the window #114

Design Alternatives

Given the user is adding an image into ImageLab,
when the image dimensions are larger than the maximum window size for their display
then
(Alt 1) ImageLab notifies the user that the image size has resulted in the display rendering
(Alt 2) the window needs to include a scroll bar so the entire image can be seen via panning.
(Alt 3) the picture is scaled to fit within the window; user notified that rendering is not true to the image selected.

Dependencies

Depends On

[UserStory] Getting an image to scale to the window #114]

Dependents

[UserStory] Getting an image to scale to the window #114]

@CamiJolly1 CamiJolly1 added the user story User Story label Oct 31, 2023
@CamiJolly1
Copy link
Contributor Author

CamiJolly1 commented Oct 31, 2023

With this issue, I would say the best option would be to not let the image to not be allowed in the first place. If the user wants to play the image, it needs to be consistent, and the image can get messed up with scaling. When scaled, the model that is seen breaks.

@KaizenPool
Copy link

Can I be assigned this issue.

@jody
Copy link
Contributor

jody commented Nov 4, 2023

With this issue, I would say the best option would be to not let the image to not be allowed in the first place. If the user wants to play the image, it needs to be consistent, and the image can get messed up with scaling. When scaled, the model that is seen breaks.

I don't think the program should disallow processing of that image just because a user's screen isn't big enough to display it.

This may also prove difficult to implement given the wide array of possible display combinations and orientations. (For example, many people have multiple physical displays that behave as a contiguous display area (such as shown in the following "settings" images).
Screen Shot 2023-11-04 at 3 21 57 PM Screen Shot 2023-11-04 at 3 24 36 PM

@jody
Copy link
Contributor

jody commented Nov 4, 2023

More immediately, the current behavior of the product needs to be documented for users so they (a) know what to expect and (b) have an explanation for their experienced product behavior.

@jody
Copy link
Contributor

jody commented Nov 4, 2023

I believe that the first acceptance criteria scenario is already met by the current product.

Scenario 1
Given the user is adding an image into ImageLab,
when the image dimensions are smaller or equal to the window size
then the picture needs to appear in a 1:1 ratio.

That is, the image is shown in 1:1 ratio. Because the 1:1 scale means that it is impossible to show the entire image, on the part that fits within the displayable region is shown. When the chooses to "filter" or "play" the image, I believe that the image data is used in full. (This should be confirmable by using a down-sizing filter.)

This behavior warrants explanation to the user, but it is consistent with the rest of the behavior of the product.

@CamiJolly1
Copy link
Contributor Author

CamiJolly1 commented Nov 7, 2023

I believe that the first acceptance criteria scenario is already met by the current product.

Scenario 1
Given the user is adding an image into ImageLab,
when the image dimensions are smaller or equal to the window size
then the picture needs to appear in a 1:1 ratio.

That is, the image is shown in 1:1 ratio. Because the 1:1 scale means that it is impossible to show the entire image, on the part that fits within the displayable region is shown. When the chooses to "filter" or "play" the image, I believe that the image data is used in full. (This should be confirmable by using a down-sizing filter.)

This behavior warrants explanation to the user, but it is consistent with the rest of the behavior of the product.

Went ahead and made changes to the issue. Took this scenario out of this section, and added it to the current behavior under "Supporting Information."

@KaizenPool KaizenPool removed their assignment Nov 9, 2023
@jody jody added enhancement New feature or request E: 3 Effort: 3 Story-Points S: Significant Severity: Significant - in the mainline plan labels Nov 20, 2023
@jody
Copy link
Contributor

jody commented Nov 20, 2023

On review, I think the addition of scroll-bars is a both appropriate and desirable behavior change. It maintains the 1:1 ratio of image and rendered pixels while allow the user to pan and thus view all parts of the image.

That splits this issue into two components:
(1) Changing the behavior of imageLab to use window scrolling with "large images"
(2) Documenting the behavior of imageLab with "large images"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: 3 Effort: 3 Story-Points enhancement New feature or request S: Significant Severity: Significant - in the mainline plan user story User Story
Projects
Status: To do
Development

No branches or pull requests

3 participants