-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UserStory] encapsulation issue in ImageLab.java #61
Comments
We do not need a stringent requirement for getter and setter methods for instance variables. We would only required them where there's explicit needs for that information to be accessed or modified from outside the class. Because is not a refactoring of the ImageLab class (it changes the interface of the class), it would be useful to maintainers to explicitly mention that internal designs of other classes may need to be modified as a result of this issue's design change. |
I updated the issue description in accordance to your concern. Please let me know if this information is sufficient. |
The supporting info looks good! It appears that there are no Acceptance Criteria, which means there's no way to determine whether or not a PR actually satisfies this User story. |
Completed triage. |
User Story
Essential components
Story
As a maintainer
I want ImageLab.java to have proper encapsulation
so that the internal implementation does not affect the external API
Supporting Info
This design change may require refactoring or modifications to the internal design of other classes.
Acceptance Criteria
Any instance variables of ImageLab.java that need to be accessed or modified by other classes are private and have accessor methods.
Dependencies
Depends On
issue #32
The text was updated successfully, but these errors were encountered: