Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed resolution to issue # 83 (Invalid File type) #110

Closed
wants to merge 13 commits into from
Closed

Proposed resolution to issue # 83 (Invalid File type) #110

wants to merge 13 commits into from

Conversation

esundbla
Copy link

@esundbla esundbla commented Apr 1, 2022

The addition of a while loop in the action listener of ImageLab to Updated. Will resolve freezing on selection of invalid file types brought up in issue #83 .The fix allows for re selection until valid file type is selected.

Contributors: @esundbla code and pull request. @babybeans, and @noah-fullerton for code review and verification.

@esundbla
Invalid File FIx
9ce2c50 
Has program exit upon selection of invalid file type

Revert "Invalid File FIx"

This reverts commit d5654ca.
@esundbla
fix invalid file type
4e15336 
Program will exit upon selection of invalid file type
@esundbla
Merge pull request #1 from Nugget3-14/ErikImgLab
5308eb9 
fix invalid file type issue 83
@esundbla
Fix is more acurate to fix described in # 83 you can re-select file t…
5465ca2 
…ypes until valid file is found
@jody
Copy link
Contributor

jody commented Apr 1, 2022 •
edited
Loading

Just glancing at the PR, I'm wondering why there are nine files changed.

It would also be good see documented assessment of the quality of the changes, such as the outcomes of tests and code checks.

I'm going to hold off on an actual review until your team has had a chance to review the appropriateness of all changes associated with this PR and some quality assessment.

@esundbla @babybeans @noah-fullerton

@esundbla
Copy link
Author

esundbla commented Apr 4, 2022

We had a chance now as a team @Nugget3-14, to review the PR. After cleaning unnecessary file changes related to individual IDE's. We now believe the PR is ready to merge!

@jody jody linked an issue Apr 5, 2022 that may be closed by this pull request
[UserStory] Notify Users of an unrecognizable file type and let user select a new file #83
Open
5 tasks
@jody
Copy link
Contributor

jody commented Apr 5, 2022

This PR appears to result in multiple regressions of the code base.
These were revealed via unit testing, checking coding conventions, and attempting to run the product.

Unit Testing
Before applying this PR, JUnit reports no errors.
After applying this PR, JUnit reports one error.

Coding Conventions
Before applying this PR, Checkstyle reports
• 9 errors in ImgProvider
• 7 errors in ImageLab
After applying this PR, Checkstyle reports
• 18 errors in ImgProvider
• 17 errors in ImageLab

Runtime Behavior
After applying this PR, running the program via
./gradlew run
disallows opening image file types that were previously recognized by the product.

Please fix problems and squash commits. Thank you!

Notify: @Nugget3-14 @esundbla @babybeans @noah-fullerton

jody
jody requested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@jody jody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: #110 (comment)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jody jody jody requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UserStory] Notify Users of an unrecognizable file type and let user select a new file
2 participants
@esundbla @jody