Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip does not build child packages #271

Open
milahu opened this issue May 11, 2022 · 4 comments · May be fixed by #272
Open

wip does not build child packages #271

milahu opened this issue May 11, 2022 · 4 comments · May be fixed by #272
Labels
bug Something isn't working

Comments

@milahu
Copy link

milahu commented May 11, 2022

nix-review pr works as expected

$ nix-review pr https://github.com/NixOS/nixpkgs/pull/171274

4 packages built:
gst_all_1.gstreamermm mapmap obs-studio-plugins.obs-gstreamer subtitleeditor

but when i run nix-review wip according to readme#review-changes-in-personal-forks
it does not build any child packages

$ nix-review wip -r https://github.com/delroth/nixpkgs -b gstreamermm-build-fix

also not when i add -p subtitleeditor

am i missing something? or is this a missing feature?
@SuperSandro2000
Copy link
Collaborator

Yes, you are missing something

    wip                 review the uncommited changes in the working tre

@milahu
Copy link
Author

milahu commented May 12, 2022 •
edited
Loading

yeah but ...

i expect nixpkgs-review to also build the affected child packges
just like nixpkgs-review pr would do

edit:

uncommited changes in the working tree

aah. so i'm looking for a pr command that accepts a branch (not a pr)

@milahu
Copy link
Author

milahu commented May 12, 2022 •
edited
Loading

am i missing something?

i was missing the rev command

nix-review rev -r https://github.com/delroth/nixpkgs -b gstreamermm-build-fix a9f5b7dbfe16c81a026946f2c9931479be31171d

but same here: child packages are not built

@SuperSandro2000
Copy link
Collaborator

I just verified wip locally which works like a charm.

Your rev example does indeed not work. I think it's using the rev for both evals which is probably not what we want here.

 ➜ nix-review rev -r https://github.com/delroth/nixpkgs -b gstreamermm-build-fix a9f5b7dbfe16c81a026946f2c9931479be31171d
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/delroth/nixpkgs gstreamermm-build-fix:refs/nixpkgs-review/0
remote: Enumerating objects: 8, done.
remote: Counting objects: 100% (5/5), done.
remote: Total 8 (delta 5), reused 5 (delta 5), pack-reused 3
Unpacking objects: 100% (8/8), 1.44 KiB | 294.00 KiB/s, done.
From https://github.com/delroth/nixpkgs
 + 80b396fa206...a9f5b7dbfe1 gstreamermm-build-fix -> refs/nixpkgs-review/0  (forced update)
$ git worktree add /home/sandro/.cache/nixpkgs-review/rev-a9f5b7dbfe16c81a026946f2c9931479be31171d/nixpkgs a9f5b7dbfe16c81a026946f2c9931479be31171d
Preparing worktree (detached HEAD a9f5b7dbfe1)
Updating files: 100% (30386/30386), done.
HEAD is now at a9f5b7dbfe1 gstreamermm: cherry-pick a gcc11 compatibility patch
$ nix-env --option system x86_64-linux -f /home/sandro/.cache/nixpkgs-review/rev-a9f5b7dbfe16c81a026946f2c9931479be31171d/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit --no-ff a9f5b7dbfe16c81a026946f2c9931479be31171d
Already up to date.
$ nix-env --option system x86_64-linux -f /home/sandro/.cache/nixpkgs-review/rev-a9f5b7dbfe16c81a026946f2c9931479be31171d/nixpkgs -qaP --xml --out-path --show-trace --meta
Nothing to be built.
$ /nix/store/ial0g4la1by8xk5a6am22wlz7wb1xhlr-nix-2.8.0/bin/nix-shell /home/sandro/.cache/nixpkgs-review/rev-a9f5b7dbfe16c81a026946f2c9931479be31171d/shell.nix

@Mic92 FYI

@SuperSandro2000 SuperSandro2000 added the bug Something isn't working label May 12, 2022
@milahu milahu linked a pull request May 12, 2022 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add branch command (draft) milahu/nixpkgs-review
2 participants
@SuperSandro2000 @milahu