Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using with nixos/release-combined.nix #405

Open
lovesegfault opened this issue Jun 19, 2024 · 1 comment
Open

Using with nixos/release-combined.nix #405

lovesegfault opened this issue Jun 19, 2024 · 1 comment

Comments

@lovesegfault
Copy link

Is there a way to use nixpkgs-review against a PR but instead of building a specific package, to build an attr within nixos/release-combined.nix such as nixos.iso_gnome.x86_64-linux?

This would be really helpful for reviewing mass-rebuild PRs (e.g. binutils bumps) where the ISO drvs offer a pretty good set of packages to build/test.

@Mic92
Copy link
Owner

Mic92 commented Jun 20, 2024

There is nothing just now. But since you are given a git checkout, you can also manually run nix-build ./nixpkgs/nixos/release-combined.nix -A nixos.iso_gnome.x86_64-linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants