Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA eval support #433

Closed
wegank opened this issue Nov 30, 2024 · 4 comments · Fixed by #435
Closed

GHA eval support #433

wegank opened this issue Nov 30, 2024 · 4 comments · Fixed by #435

Comments

@wegank
Copy link

wegank commented Nov 30, 2024

Since NixOS/nixpkgs#359704, there is an evaluation output available as an artifact in the Eval / Process (pull_request_target) check. It would be nice to reuse it to skip local evaluation.

@Mic92
Copy link
Owner

Mic92 commented Dec 4, 2024

@GaetanLepage is working on this.

@GaetanLepage
Copy link
Contributor

Yes, I have started to look at it and will work on it this WE.

@getchoo
Copy link

getchoo commented Dec 7, 2024

Is ./ci/eval faster than the current method used for local eval? Could be nice for running nixpkgs-review rev HEAD before pushing

@GaetanLepage
Copy link
Contributor

Is ./ci/eval faster than the current method used for local eval? Could be nice for running nixpkgs-review rev HEAD before pushing

Well, there are two things that I want to add to nixpkgs-review:

  1. Retrieving the eval results from the GHA (when available) to prevent doing any work locally.
  2. Use the new eval code in ci/eval to perform multi-threaded evaluation locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants