Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use nixpkgs-review rev HEAD to check local commits added to an existing pull request #458

Open
dwt opened this issue Jan 28, 2025 · 0 comments

Comments

@dwt
Copy link

dwt commented Jan 28, 2025

This can be seen on NixOS/nixpkgs#366387 where I tried to checkout a PR do some local modifications and then tried to build it. That got me errors like this.

Now... did I do something wrong there or is this expected behavior? Quite possibly I do not understand correctly how it is supposed to work to improve pull requests from other people and make (tested) suggestions on how to improve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant