Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LookupClient.QueryAsync concurrency issues #230

Open
bfortman opened this issue Aug 26, 2024 · 1 comment
Open

LookupClient.QueryAsync concurrency issues #230

bfortman opened this issue Aug 26, 2024 · 1 comment
Milestone

Comments

@bfortman
Copy link

Summary:
When making concurrent calls to LookupClient.QueryAsync it is possible to have query response data collisions. This issue was previously detailed out in a previous issue #209 . The changes made for #218 improve the likelihood of success, but they do not guarantee it.

Suggested fix:
I believe the correct solution to this problem would be to add a factory that does not allow duplicate active IDs. The factory would be in charge of tracking any "in use IDs" and therefore would have the information needed to always return a unique ID in relation to any currently in use IDs.

Repository owner deleted a comment Aug 27, 2024
@MichaCo
Copy link
Owner

MichaCo commented Sep 24, 2024

I'll think about something.

@MichaCo MichaCo added this to the 1.8.1 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@MichaCo @bfortman and others