Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Credentialhandeling #3

Open
crnnr opened this issue Nov 5, 2023 · 1 comment
Open

Cleanup: Credentialhandeling #3

crnnr opened this issue Nov 5, 2023 · 1 comment

Comments

@crnnr
Copy link
Contributor

crnnr commented Nov 5, 2023

Multiple instances of plain text passwords/Usernames in files. These should be read from environment variables IMO.
@MichaMican
Copy link
Owner

All Secrets were sanatized an rotated - in Code only placeholders are inuse instead of the actual secrets.

For the Python Script - env variables are definately viable, for the ESP Code though it's not that simple i'm afraid.
Will change the Python part though next time i work in that project

Repository owner locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaMican @crnnr