Skip to content

Commit f45bb98

Browse files
authored
[CIR] Upstream CXXRewrittenBinaryOperator for Scalar expr (llvm#167210)
Upstream the CXXRewrittenBinaryOperator support for Scalar expr
1 parent 4e37eaf commit f45bb98

File tree

2 files changed

+43
-0
lines changed

2 files changed

+43
-0
lines changed

clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -438,6 +438,10 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
438438
return cgf.emitVAArg(ve);
439439
}
440440

441+
mlir::Value VisitCXXRewrittenBinaryOperator(CXXRewrittenBinaryOperator *e) {
442+
return Visit(e->getSemanticForm());
443+
}
444+
441445
mlir::Value VisitUnaryExprOrTypeTraitExpr(const UnaryExprOrTypeTraitExpr *e);
442446
mlir::Value
443447
VisitAbstractConditionalOperator(const AbstractConditionalOperator *e);
Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-cir %s -o %t.cir
2+
// RUN: FileCheck --input-file=%t.cir %s -check-prefix=CIR
3+
// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-llvm %s -o %t-cir.ll
4+
// RUN: FileCheck --input-file=%t-cir.ll %s -check-prefix=LLVM
5+
// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -Wno-unused-value -emit-llvm %s -o %t.ll
6+
// RUN: FileCheck --input-file=%t.ll %s -check-prefix=OGCG
7+
8+
struct HasOpEq {
9+
bool operator==(const HasOpEq &) const;
10+
};
11+
12+
void cxx_rewritten_binary_operator_scalar_expr() {
13+
HasOpEq a;
14+
HasOpEq b;
15+
bool neq = a != b;
16+
}
17+
18+
// CIR: %[[A_ADDR:.*]] = cir.alloca !rec_HasOpEq, !cir.ptr<!rec_HasOpEq>, ["a"]
19+
// CIR: %[[B_ADDR:.*]] = cir.alloca !rec_HasOpEq, !cir.ptr<!rec_HasOpEq>, ["b"]
20+
// CIR: %[[NEQ_ADDR:.*]] = cir.alloca !cir.bool, !cir.ptr<!cir.bool>, ["neq", init]
21+
// CIR: %[[EQ:.*]] = cir.call @_ZNK7HasOpEqeqERKS_(%[[A_ADDR]], %[[B_ADDR]]) : (!cir.ptr<!rec_HasOpEq>, !cir.ptr<!rec_HasOpEq>) -> !cir.bool
22+
// CIR: %[[NEQ:.*]] = cir.unary(not, %[[EQ]]) : !cir.bool, !cir.bool
23+
// CIR: cir.store{{.*}} %[[NEQ]], %[[NEQ_ADDR]] : !cir.bool, !cir.ptr<!cir.bool>
24+
25+
// LLVM: %[[A_ADDR:.*]] = alloca %struct.HasOpEq, i64 1, align 1
26+
// LLVM: %[[B_ADDR:.*]] = alloca %struct.HasOpEq, i64 1, align 1
27+
// LLVM: %[[NEQ_ADDR:.*]] = alloca i8, i64 1, align 1
28+
// LLVM: %[[EQ:.*]] = call i1 @_ZNK7HasOpEqeqERKS_(ptr %[[A_ADDR]], ptr %[[B_ADDR]])
29+
// LLVM: %[[NEQ_I1:.*]] = xor i1 %[[EQ]], true
30+
// LLVM: %[[NEQ:.*]] = zext i1 %[[NEQ_I1]] to i8
31+
// LLVM: store i8 %[[NEQ]], ptr %[[NEQ_ADDR]], align 1
32+
33+
// OGCG: %[[A_ADDR:.*]] = alloca %struct.HasOpEq, align 1
34+
// OGCG: %[[B_ADDR:.*]] = alloca %struct.HasOpEq, align 1
35+
// OGCG: %[[NEQ_ADDR:.*]] = alloca i8, align 1
36+
// OGCG: %[[EQ:.*]] = call {{.*}} zeroext i1 @_ZNK7HasOpEqeqERKS_(ptr {{.*}} %[[A_ADDR]], ptr {{.*}} %[[B_ADDR]])
37+
// OGCG: %[[NEQ_I1:.*]] = xor i1 %[[EQ]], true
38+
// OGCG: %[[NEQ:.*]] = zext i1 %[[NEQ_I1]] to i8
39+
// OGCG: store i8 %[[NEQ]], ptr %[[NEQ_ADDR]], align 1

0 commit comments

Comments
 (0)