Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check failure with PROJ 6 and GDAL 3 #23

Closed
rsbivand opened this issue Oct 29, 2019 · 2 comments · Fixed by #25
Closed

check failure with PROJ 6 and GDAL 3 #23

rsbivand opened this issue Oct 29, 2019 · 2 comments · Fixed by #25

Comments

@rsbivand
Copy link

Your package fails with rgdal and sf built with PROJ 6 and GDAL 3. PROJ >= 6 will become mandatory early in 2020. See also r-spatial/discuss#28.
00check.zip

@rsbivand
Copy link
Author

Not fixed in 0.3.0:

* checking tests ... ERROR
  Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  > library(testthat)
  > library(mockery)
  > library(geohashTools)
  > 
  > test_check("geohashTools")
  ── 1. Failure: gh_covering works (@test-gis-tools.R#136)  ──────────────────────
  `banjarmasin_tight` not identical to sp::`proj4string<-`(...).
  Attributes: < Component "proj4string": Attributes: < Component "comment": 1 string mismatch > >
  
  ══ testthat results  ═══════════════════════════════════════════════════════════
  [ OK: 111 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ]
  1. Failure: gh_covering works (@test-gis-tools.R#136) 
  
  Error: testthat unit tests failed
  Execution halted

If fixed in development version, please check with rgdal from R-Forge, PROJ > 5 and GDAL > 2, and then release.

@rsbivand
Copy link
Author

rgdal will be released very soon, and your package will then have a very short grace period before being archived. Do please resolve this issue, for example using http://spatial.nhh.no/R/rgdal/rtools4-zips/ as Windows binary packages to reproduce the problems. Your use of sp::proj4string must be fully revised and adapted to the new structures discussed in https://www.r-spatial.org/r/2020/03/17/wkt.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant