-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resizing results in overlapping images. #12
Comments
Fork with fix at SpiGAndromeda/ts-image-processor . |
If you already fixed it, could you make a PR? THANK YOU!! :) |
@MickL Done. Very fast response. Nice! |
I am not exactly sure how to reproduce the overlapping images. Could you give me instructions so I can understand the problem? |
Can you reproduce it on the demo page? Please note there seems to be a bug I just found that it only accepts jpg |
Just JPEGs? Ok. I used a JPEG of the pure text but the result was ok in demo. Also note that the demo uses default options in the source pipe, which means that data URLs are extracted from canvas as JPEG. |
I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project
Summary
When Resizing images the resize function in resize.js draws in a loop to the same canvas. This can result in multiple overlapping images (with different size) on the same canvas. The cropping function at the end doesn't remove them.
Other information
I will do a forx and see how to fix it nicely. My first working approach (local) was to uzitlize the helperCamvas of the canvasService. I think a new function in the canvasService will do this nicely.
best regards,
spigandromeda
P.S. this is a really nice package. Good work!
The text was updated successfully, but these errors were encountered: