Skip to content
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.

Testing .NET Core 2.0 DependencyCollector #572

Closed
lmolkova opened this issue May 12, 2017 · 3 comments
Closed

Testing .NET Core 2.0 DependencyCollector #572

lmolkova opened this issue May 12, 2017 · 3 comments
Milestone

Comments

@lmolkova
Copy link
Member

lmolkova commented May 12, 2017

We have code that is specific for .net core 2.0 runtime (in DependencyCollector.NetCore).
Testing it requires dotnet core 2.0 runtime and tools in build infra.

Unit tests for DependencytracingModule on core should also run on 2.0 with additional checks for IsEnabled

@dnduffy
Copy link
Member

dnduffy commented May 12, 2017

Does that mean no support for 1.0.* anymore or is the 2.0 code #ifdef'ed?

@lmolkova
Copy link
Member Author

lmolkova commented May 12, 2017

there is code that listens to events that fired on .NET Core 2.0 only. DepCollector still targets netstandard 1.6 and there are no ifdefs, but the logic for 2.0 just lights up when user has 2.0 runtime

@dnduffy
Copy link
Member

dnduffy commented May 12, 2017

Excellent. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants