Added a changelog. #1230
Merged
Added a changelog. #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
justinwilaby
as code owners
tonyanziano
force-pushed
the
toanzian/#1161-changelog
branch
from
ec956b2
to
068aaf6
Compare
Pull Request Test Coverage Report for Build 1847
💛 - Coveralls |
corinagum
previously approved these changes
Jan 15, 2019
|
Maybe leave open for discussion for a bit, but I'm all for this update :) |
a-b-r-o-w-n
reviewed
Jan 15, 2019
CHANGELOG.md
Outdated
|
|
||
| ## Unreleased | ||
| ### Added | ||
| - Added changelog in PR [#1230](https://github.com/Microsoft/BotFramework-Emulator/pull/1230) |
There was a problem hiding this comment.
I think we should "tag" each change.
ex: [ui], [core], [build], etc.
There was a problem hiding this comment.
So in the case of modifying something like the README or this CHANGELOG what sort of tag would we use? [docs]? or [infrastructure]?
There was a problem hiding this comment.
I think docs makes sense. This is based on https://www.npmjs.com/package/commitizen (which I'd like to introduce at some point), but we can discuss what those tags should be.
tonyanziano
force-pushed
the
toanzian/#1161-changelog
branch
from
068aaf6
to
587280a
Compare
a-b-r-o-w-n
approved these changes
Jan 17, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1161
===
Follows the same format as Webchat's changelog.
So for example:
All of our current changes until we release v4.3 will go in the
Unreleasedsection. Then, once 4.3 is released, we copy all the changes fromUnreleasedinto the4.3.0section and wipe out theUnreleasedsection. Then the next set of changes will continue to be added toUnreleaseduntil we decide to cut another version (v4.3.1, or v4.4.0, etc.).Possible change categories under each section include:
I'm completely open to discussion about this format. Reference docs here.