Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed secret prompt dialog's opaque background. #1407

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

tonyanziano
Copy link
Contributor

The secret prompt dialog had an opaque background which blocked out all of the underlying app.

===

Before:

modal_before

After:

modal_after

@coveralls
Copy link

coveralls commented Apr 2, 2019

Pull Request Test Coverage Report for Build 2276

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.411%

Totals Coverage Status
Change from base Build 2270: 0.0%
Covered Lines: 4893
Relevant Lines: 8321

💛 - Coveralls

@justinwilaby
Copy link
Contributor

I believe this was by design. If the botfile is encrypted, the Emulator cannot function until it is decrypted. The opacity: 1 seems fairly deliberate.

@tonyanziano
Copy link
Contributor Author

Hmm, I'll ask design and see what they say. It seems really weird and jarring to have the entire UI obscured by a dialog when none of the other modals do that.

You aren't able to interact with the underlying UI anyways when a modal is active, or at least you used to not be able to because of the focus trap logic, but I think that regressed when the Fabric to Non-Fabric switch happened.

@tonyanziano
Copy link
Contributor Author

Just checked with @mewa1024 and confirmed that it is supposed to be transparent and follow the same design pattern as the other dialogs.

@tonyanziano tonyanziano merged commit 0aef3c2 into master Apr 3, 2019
@tonyanziano tonyanziano deleted the toanzian/modal-fix branch April 3, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants