Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ipc issue that was breaking the command service. #1418

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Fixed ipc issue that was breaking the command service. #1418

merged 1 commit into from
Apr 10, 2019

Conversation

tonyanziano
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Apr 10, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2306

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.414%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ipc.ts 3 4 75.0%
Totals Coverage Status
Change from base Build 2297: 0.0%
Covered Lines: 4894
Relevant Lines: 8322
💛 - Coveralls

justinwilaby
justinwilaby approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit:

@tonyanziano tonyanziano merged commit 3775691 into master Apr 10, 2019
@tonyanziano tonyanziano deleted the toanzian/package-fix branch April 10, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyanziano @coveralls @justinwilaby