Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: change the attachment icon from picture to a clip #1264

Closed
compulim opened this issue Oct 31, 2018 · 4 comments · Fixed by #1506
Closed

Bug: change the attachment icon from picture to a clip #1264

compulim opened this issue Oct 31, 2018 · 4 comments · Fixed by #1506
Assignees
@corinagum
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner p2 Nice to have size-s 1 days or less
Milestone
v4.3

Comments

@compulim
Copy link
Contributor

compulim commented Oct 31, 2018 •
edited
Loading

If it show a photo icon, the user should not be able to upload non-photo attachment, e.g. ZIP files.

image

Comparison to v3

image
@compulim compulim changed the title Bug Bug: change the attachment icon from picture to a clip Oct 31, 2018
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. 4.1 p2 Nice to have labels Oct 31, 2018
@compulim compulim added this to the v4.1 milestone Oct 31, 2018
@compulim compulim added the needs-design-input UX/UI design item label Oct 31, 2018
@compulim
Copy link
Contributor Author

v3 also use the same icon, for both photo and non-photo.

@compulim compulim added 4.2 and removed 4.1 labels Oct 31, 2018
@compulim compulim modified the milestones: v4.1, v4.2 Oct 31, 2018
@corinagum
Copy link
Contributor

@mewa1024 Not sure if this is a you or Marc request, he said he would touch base with you!

@corinagum corinagum assigned corinagum and unassigned corinagum Nov 21, 2018
@DesignPolice
Copy link

ping

@mewa1024
Copy link

@DesignPolice paper clips seems fine to me. Looks like some messenging apps breakout all the files types, but that probably won't scale for Webchat.

@sgellock sgellock added 4.3 and removed 4.2 labels Nov 27, 2018
@compulim compulim modified the milestones: v4.2, v4.3 Nov 28, 2018
@compulim compulim added the size-s 1 days or less label Dec 8, 2018
@corinagum corinagum mentioned this issue Dec 18, 2018
Merged
@compulim compulim modified the milestone: v4.3 Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner p2 Nice to have size-s 1 days or less
Projects
None yet
Milestone
v4.3
Development

Successfully merging a pull request may close this issue.

Accessibility & Icon fixes corinagum/BotFramework-WebChat
5 participants
@sgellock @compulim @corinagum @mewa1024 @DesignPolice