Adding Jsrt function JsCopyStringOneByte #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalinfinity
approved these changes
Jul 20, 2017
| @@ -679,5 +679,42 @@ CHAKRA_API | |||
| _In_ JsPropertyIdRef propertyId, | |||
| _Out_ bool *hasOwnProperty); | |||
|
|
|||
| /// <summary> | |||
| /// Write JS string value into char string buffer without a null terminator | |||
There was a problem hiding this comment.
Can you add some more details about the semantics of this API, specifically what happens if the codepoint being copied is not within the char range
There was a problem hiding this comment.
I had addressed that at https://github.com/Microsoft/ChakraCore/pull/3408/files#diff-ffd84896ce29f73bbba0ed9612cf37b2R699 unless you feel that is unclear?
There was a problem hiding this comment.
Ah yes, that's great. Also clarify that UTF16 encoded codepoints are being truncated in this case. Actually, what happens in the case of a surrogate pair?
For scenarios where a string is known to have values fitting in one byte, this method allows directly copying those values into a char* buffer rather than having to copy to a uint16_t* buffer and then to a char* buffer, and treating the string as raw bytes rather than a valid utf8 encoding.
MSLaguana
force-pushed
the
addJsrtOneByteStringCopy
branch
from
1a36fd6 to
9020556
Compare
chakrabot
pushed a commit
that referenced
this pull request
Jul 21, 2017
Merge pull request #3408 from MSLaguana:addJsrtOneByteStringCopy For scenarios where a string is known to have values fitting in one byte, this method allows directly copying those values into a char* buffer rather than having to copy to a uint16_t* buffer and then to a char* buffer, and treating the string as raw bytes rather than a valid utf8 encoding. This will help reduce overhead in some common nodejs use cases.
chakrabot
pushed a commit
that referenced
this pull request
Jul 21, 2017
…ngOneByte Merge pull request #3408 from MSLaguana:addJsrtOneByteStringCopy For scenarios where a string is known to have values fitting in one byte, this method allows directly copying those values into a char* buffer rather than having to copy to a uint16_t* buffer and then to a char* buffer, and treating the string as raw bytes rather than a valid utf8 encoding. This will help reduce overhead in some common nodejs use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For scenarios where a string is known to have values fitting in
one byte, this method allows directly copying those values into a
char* buffer rather than having to copy to a uint16_t* buffer
and then to a char* buffer, and treating the string as raw bytes
rather than a valid utf8 encoding.
This will help reduce overhead in some common nodejs use cases.