Better handling of proxy errors / prevent infinite retries when exceptions occur #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbelcher-MSFT
suggested changes
Feb 7, 2018
StoreBroker/StoreBroker.psd1
Outdated
| @@ -6,7 +6,7 @@ | |||
| CompanyName = 'Microsoft Corporation' | |||
| Copyright = 'Copyright (C) Microsoft Corporation. All rights reserved.' | |||
|
|
|||
| ModuleVersion = '1.14.2' | |||
| ModuleVersion = '1.14.3' | |||
There was a problem hiding this comment.
We're already at 1.14.3!
There was a problem hiding this comment.
We weren't at the time that I pushed the PR. Updated.
HowardWolosky
force-pushed
the
flightFix
branch
from
f096098 to
8b2b17a
Compare
danbelcher-MSFT
approved these changes
Feb 8, 2018
…exceptions occur An exception that the Proxy might return will not contiain a `message` property within the exception's `InnerMessage`, but the current error reporting logic assumed that there would be a `message` property and then tried to call `Trim()` on it. This resulted in a `You cannot call a method on a null-valued expression.` exception. Because that exception occurred within a try/catch that was within a catch statement, the outer catch ended up eating the exception, resulting in the retry loop continuing to try the command, over and over again. There are two distinct fixes in here as a result: 1. Only try to call `Trim()` if `InnerMessage.message` exists, otherwise, just report back `InnerMessage` itself. 2. Make sure that the outer catch statement ends with a `throw` to ensure that any inner exceptions thrown will propagate. As a result, we will also explicitly `continue` the loop if we are going to perform an auto-retry.
HowardWolosky
force-pushed
the
flightFix
branch
from
8b2b17a to
c2837ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An exception that the Proxy might return will not contiain a
messagepropertywithin the exception's
InnerMessage, but the current error reporting logicassumed that there would be a
messageproperty and then tried to callTrim()on it. This resulted in a
You cannot call a method on a null-valued expression.exception.
Because that exception occurred within a try/catch that was within a catch statement,
the outer catch ended up eating the exception, resulting in the retry loop continuing
to try the command, over and over again.
There are two distinct fixes in here as a result:
Only try to call
Trim()ifInnerMessage.messageexists, otherwise,just report back
InnerMessageitself.Make sure that the outer catch statement ends with a
throwto ensurethat any inner exceptions thrown will propagate. As a result, we will
also explicitly
continuethe loop if we are going to perform an auto-retry.