v1.1.1 - Add a logger option to print timestamps in UTC for log traces #15
Conversation
|
Hi @HowardWolosky-MSFT, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| { | ||
| $dateString = $date.ToUniversalTime().ToString("yyyy-MM-dd HH:mm:ss") | ||
| } | ||
|
|
There was a problem hiding this comment.
It looks like both the Local Time and UTC are being presented in the same format. How can we tell if a given log file uses UTC or Local Time? Are we logging the value of $global:SBUseUTC?
There was a problem hiding this comment.
You can also use the 'Z' postfix or offsets for the timestamps: http://www.w3.org/TR/NOTE-datetime
There was a problem hiding this comment.
Good suggestion. Done.
Write-Log is used for writing all messages to the console and the log file. It embeds a timestamp with each message, but this timestamp uses LocalTime. A request has come in to optionally allow users to have this timestamp recorded in UTC instead of LocalTime. This adds a new global variable $global:SBUseUTC that defaults to $false. If set to $true, then Write-Log will use UTC for the timestamps, appending a "Z" to the end of the timestamp based on http://www.w3.org/TR/NOTE-datetime. The documentation has been updated to reflect this new configuration option. * Additionally fixed a typo in Write-Log where it was trying to call Write-Debug. Resolves #10: Add a logger option to print timestamps in UTC for log traces
Write-Logis used for writing all messages to the console and the log file.It embeds a timestamp with each message, but this timestamp uses LocalTime.
A request has come in to optionally allow users to have this timestamp
recorded in UTC instead of LocalTime.
This adds a new global variable
$global:SBUseUTCthat defaults to$false.If set to
$true, thenWrite-Logwill use UTC for the timestamps.The documentation has been updated to reflect this new
configuration option.
Write-Logwhere it was trying tocall
Write-Debug.Resolves #10: Add a logger option to print timestamps in UTC for log traces