Clarify behavior of Dev Portal with new submissions #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @HowardWolosky, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
We have a warning on Commit that changes to a submission can't be seen in the Dev Portal until the submission enters the Certification phase, however we weren't providing that warning right after a submission was patched, which was leading to some user confusion of why they couldn't see their changes. The warning has been moved to a single location and is now referenced throughout the module. Additionally, normalized the capitalization of the phrase "Dev Portal" throughout the module.
HowardWolosky
force-pushed
the
fix/feedback
branch
from
306142f to
846e0c8
Compare
danbelcher-MSFT
approved these changes
Feb 18, 2017
| $output += " https://dev.windows.com/en-us/dashboard/apps/$AppId/submissions/$submissionId/" | ||
| $output += "or by running this command:" | ||
| $output += " Get-ApplicationSubmission -AppId $AppId -SubmissionId $submissionId | Format-ApplicationSubmission" | ||
| $output += "" | ||
| $output += $script:manualPublishWarning -f 'Update-ApplicationSubmission' |
There was a problem hiding this comment.
Wondering if we should get in the habit of creating string constants for referencing our functions, since we do that a lot.
There was a problem hiding this comment.
Interesting suggestion. Won't block this change on that suggestion, but will consider it for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a warning on Commit that changes to a submission can't be seen
in the Dev Portal until the submission enters the Certification phase,
however we weren't providing that warning right after a submission was
patched, which was leading to some user confusion of why they couldn't
see their changes.
The warning has been moved to a single location and is now referenced
throughout the module.
Additionally, normalized the capitalization of the phrase "Dev Portal"
throughout the module.