Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add seed parameters to lightgbm #1387

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #1387 (c2e9a57) into master (f11563b) will decrease coverage by 0.09%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
- Coverage   84.57%   84.48%   -0.10%     
==========================================
  Files         291      284       -7     
  Lines       14454    14395      -59     
  Branches      715      710       -5     
==========================================
- Hits        12225    12162      -63     
- Misses       2229     2233       +4     
Impacted Files Coverage Δ
...ure/synapse/ml/lightgbm/dataset/DatasetUtils.scala 61.11% <ø> (ø)
...re/synapse/ml/lightgbm/params/LightGBMParams.scala 81.84% <56.25%> (-2.63%) ⬇️
...oft/azure/synapse/ml/lightgbm/swig/SwigUtils.scala 88.88% <84.84%> (-8.34%) ⬇️
...osoft/azure/synapse/ml/lightgbm/LightGBMBase.scala 94.56% <85.71%> (-0.38%) ⬇️
...soft/azure/synapse/ml/lightgbm/LightGBMUtils.scala 78.46% <93.75%> (+3.95%) ⬆️
...azure/synapse/ml/lightgbm/LightGBMClassifier.scala 91.11% <100.00%> (ø)
...oft/azure/synapse/ml/lightgbm/LightGBMRanker.scala 60.56% <100.00%> (ø)
.../azure/synapse/ml/lightgbm/LightGBMRegressor.scala 74.13% <100.00%> (ø)
...crosoft/azure/synapse/ml/lightgbm/TrainUtils.scala 86.07% <100.00%> (+0.08%) ⬆️
...ynapse/ml/lightgbm/dataset/DatasetAggregator.scala 95.75% <100.00%> (+0.23%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f11563b...c2e9a57. Read the comment docs.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-seed branch 3 times, most recently from ce1c94c to 79c98bc Compare February 16, 2022 03:50
@imatiach-msft imatiach-msft changed the title [WIP] add seed parameters to lightgbm fix: add seed parameters to lightgbm Feb 16, 2022
@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Ilya!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants