Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade the univariate anomaly detection version to v1.1-preview #1440

Merged
merged 12 commits into from
Mar 15, 2022

Conversation

yalaudah
Copy link
Contributor

This PR upgrades the version of the univariate anomaly detection API endpoint to v1.1-preview.1 to add support for an optional parameter imputeMode in the input, and expect severity scores in the output.

@yalaudah yalaudah requested a review from mhamilton723 as a code owner March 14, 2022 22:43
@yalaudah
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yalaudah
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yalaudah
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #1440 (7eb3030) into master (73d9a75) will decrease coverage by 2.02%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master    #1440      +/-   ##
==========================================
- Coverage   84.65%   82.63%   -2.03%     
==========================================
  Files         288      281       -7     
  Lines       14298    14177     -121     
  Branches      716      712       -4     
==========================================
- Hits        12104    11715     -389     
- Misses       2194     2462     +268     
Impacted Files Coverage Δ
.../azure/synapse/ml/cognitive/AnomalyDetection.scala 80.00% <66.66%> (-3.17%) ⬇️
.../synapse/ml/cognitive/AnomalyDetectorSchemas.scala 100.00% <100.00%> (ø)
...m/src/main/scala/com/microsoft/lightgbm/SWIG.scala 0.00% <0.00%> (-100.00%) ⬇️
...azure/synapse/ml/lightgbm/LightGBMClassifier.scala 11.11% <0.00%> (-80.00%) ⬇️
...t/azure/synapse/ml/lightgbm/LightGBMDelegate.scala 0.00% <0.00%> (-50.00%) ⬇️
.../synapse/ml/lightgbm/booster/LightGBMBooster.scala 54.41% <0.00%> (-35.30%) ⬇️
...crosoft/azure/synapse/ml/lightgbm/TrainUtils.scala 56.05% <0.00%> (-27.39%) ⬇️
...org/apache/spark/ml/param/JsonEncodableParam.scala 53.33% <0.00%> (-26.67%) ⬇️
.../synapse/ml/lightgbm/dataset/LightGBMDataset.scala 42.68% <0.00%> (-20.74%) ⬇️
...osoft/azure/synapse/ml/lightgbm/LightGBMBase.scala 79.77% <0.00%> (-15.17%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d9a75...7eb3030. Read the comment docs.

@yalaudah
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yalaudah
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this awesome contribution!

@yalaudah
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yalaudah
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yalaudah yalaudah merged commit f546ab0 into microsoft:master Mar 15, 2022
@yalaudah yalaudah deleted the yaalauda/ad-api-upgrade branch March 15, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants