-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lightgbm getting stuck when empty partition is chosen as the main worker in singleDatasetMode #1458
Merged
mhamilton723
merged 1 commit into
microsoft:master
from
imatiach-msft:ilmat/fix-lightgbm-stuck
Mar 31, 2022
Merged
fix: lightgbm getting stuck when empty partition is chosen as the main worker in singleDatasetMode #1458
mhamilton723
merged 1 commit into
microsoft:master
from
imatiach-msft:ilmat/fix-lightgbm-stuck
Mar 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
force-pushed
the
ilmat/fix-lightgbm-stuck
branch
from
March 30, 2022 05:02
8036c82
to
375f08f
Compare
imatiach-msft
changed the title
Fix lightgbm getting stuck when empty partition is chosen as the main worker in singleDatasetMode
fix: lightgbm getting stuck when empty partition is chosen as the main worker in singleDatasetMode
Mar 30, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1458 +/- ##
==========================================
- Coverage 84.41% 84.31% -0.10%
==========================================
Files 295 288 -7
Lines 14761 14633 -128
Branches 705 709 +4
==========================================
- Hits 12460 12338 -122
+ Misses 2301 2295 -6
Continue to review full report at Codecov.
|
svotaw
reviewed
Mar 30, 2022
lightgbm/src/main/scala/com/microsoft/azure/synapse/ml/lightgbm/TaskTrainingMethods.scala
Outdated
Show resolved
Hide resolved
imatiach-msft
force-pushed
the
ilmat/fix-lightgbm-stuck
branch
from
March 31, 2022 04:43
375f08f
to
cf55dbb
Compare
…n worker in singleDatasetMode
imatiach-msft
force-pushed
the
ilmat/fix-lightgbm-stuck
branch
from
March 31, 2022 04:46
cf55dbb
to
aca0398
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lightgbm can get stuck when SingleDatasetMode is enabled and if an empty partition is, by random chance, chosen as the main worker in the executor.
The fix is to only allow non-empty partitions to be chosen as the main worker.
Tests
Run the test "Verify LightGBM Classifier won't get stuck on empty partitions" in the file:
https://github.com/microsoft/SynapseML/blob/master/lightgbm/src/test/scala/com/microsoft/azure/synapse/ml/lightgbm/split1/VerifyLightGBMClassifier.scala#L610
many times, by random chance it will often get stuck after several runs.
Dependency chances
No dependency changes.