fix: Upgrade and fix Dockerfiles #1472
Conversation
tools/docker/demo/Dockerfile
Outdated
|
|
||
| ARG SPARK_VERSION=3.2.0 | ||
| ARG MMLSPARK_VERSION=0.9.5 |
There was a problem hiding this comment.
nit: we might want to rename this to SYNAPSEML_VERSION
| ENV PYTHONPATH $SPARK_HOME/python/:$SPARK_HOME/python/lib/py4j*:$PYTHON_PATH | ||
| ENV PATH $SPARK_HOME/bin/:$SPARK_HOME/python/:$PATH | ||
|
|
||
| RUN apt-get remove --purge -y \ |
There was a problem hiding this comment.
I think this needs to be run when apt-get install happens otherwise it will only increase the image size
There was a problem hiding this comment.
I think you might be talking about apt-get autoclean / autoremove. This remove sub-command is to remove packages we installed in the first run on Line 13. Let me know if I am wrong here.
| @@ -0,0 +1,18 @@ | |||
| # demo Dockerfile | |||
There was a problem hiding this comment.
Thanks for documenting :)!
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1472 +/- ##
==========================================
- Coverage 84.43% 84.41% -0.03%
==========================================
Files 295 295
Lines 14779 14779
Branches 714 714
==========================================
- Hits 12479 12475 -4
- Misses 2300 2304 +4
Continue to review full report at Codecov.
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Summary
This Pull Request upgrades and fixes Dockerfiles that users can build images locally and run synapseml notebooks to experiment easily.
Tests
N/A
Dependency chances
None
AB#1745424