Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: stabilize unit tests #1576

Merged
merged 4 commits into from
Jul 21, 2022
Merged

test: stabilize unit tests #1576

merged 4 commits into from
Jul 21, 2022

Conversation

memoryz
Copy link
Contributor

@memoryz memoryz commented Jul 21, 2022 •
edited by mhamilton723
Loading

Signed-off-by: Jason Wang jasowang@microsoft.com

Summary

Trying to stabilize 2 flaky unit tests.

AB#1890042

@memoryz
fix: stablize unit tests
9fd90e5 
Signed-off-by: Jason Wang <jasowang@microsoft.com>
@memoryz
Copy link
Contributor Author

memoryz commented Jul 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022 •
edited
Loading

Codecov Report

Merging #1576 (24b0c8b) into master (4868e8b) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1576      +/-   ##
==========================================
+ Coverage   83.55%   83.69%   +0.14%     
==========================================
  Files         305      305              
  Lines       15776    15776              
  Branches      732      732              
==========================================
+ Hits        13181    13204      +23     
+ Misses       2595     2572      -23
Impacted Files Coverage Δ
...zure/synapse/ml/stages/PartitionConsolidator.scala 95.74% <0.00%> (+2.12%) ⬆️
...oft/azure/synapse/ml/opencv/ImageTransformer.scala 94.50% <0.00%> (+4.31%) ⬆️
...crosoft/azure/synapse/ml/param/ArrayMapParam.scala 69.69% <0.00%> (+6.06%) ⬆️
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 82.35% <0.00%> (+7.35%) ⬆️
...rosoft/azure/synapse/ml/param/DataFrameParam.scala 78.57% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f3a58...24b0c8b. Read the comment docs.

@memoryz
Copy link
Contributor Author

memoryz commented Jul 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz
Copy link
Contributor Author

memoryz commented Jul 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz
Copy link
Contributor Author

memoryz commented Jul 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz
Copy link
Contributor Author

memoryz commented Jul 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz memoryz changed the title fix: stablize unit tests fix: stabilize unit tests Jul 21, 2022
@memoryz memoryz changed the title fix: stabilize unit tests test: stabilize unit tests Jul 21, 2022
@memoryz
Copy link
Contributor Author

memoryz commented Jul 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mhamilton723
mhamilton723 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are awesome!!

@memoryz memoryz marked this pull request as ready for review July 21, 2022 19:52
@memoryz memoryz enabled auto-merge (squash) July 21, 2022 20:00
@memoryz
Copy link
Contributor Author

memoryz commented Jul 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz memoryz merged commit 7c34fc4 into microsoft:master Jul 21, 2022
@memoryz memoryz deleted the jasowang/unittest branch October 4, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhamilton723 mhamilton723 mhamilton723 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@memoryz @codecov-commenter @mhamilton723