feat: annual Vowpal Wabbit improvements #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, model loading,...)
vw/src/main/scala/com/microsoft/azure/synapse/ml/vw/BanditEstimatorCressieRead.scala
Outdated
Show resolved
Hide resolved
vw/src/main/scala/com/microsoft/azure/synapse/ml/vw/BanditEstimatorCressieRead.scala
Outdated
Show resolved
Hide resolved
vw/src/main/scala/com/microsoft/azure/synapse/ml/vw/BanditEstimatorCressieReadInterval.scala
Outdated
Show resolved
Hide resolved
vw/src/main/scala/com/microsoft/azure/synapse/ml/vw/VowpalWabbitBaseModelSpark.scala
Show resolved
Hide resolved
vw/src/main/scala/com/microsoft/azure/synapse/ml/vw/VowpalWabbitBaseProgressive.scala
Outdated
Show resolved
Hide resolved
vw/src/main/scala/com/microsoft/azure/synapse/ml/vw/VowpalWabbitBaseProgressive.scala
Show resolved
Hide resolved
vw/src/main/scala/com/microsoft/azure/synapse/ml/vw/VowpalWabbitBaseProgressive.scala
Outdated
Show resolved
Hide resolved
vw/src/main/scala/com/microsoft/azure/synapse/ml/vw/VowpalWabbitGeneric.scala
Outdated
Show resolved
Hide resolved
vw/src/test/scala/com/microsoft/azure/synapse/ml/vw/VerifyBanditEstimator.scala
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| "df = (\n", | ||
| " spark.read.format(\"text\")\n", | ||
| " .schema(schema)\n", | ||
| " .load(\"wasbs://publicwasb@mmlspark.blob.core.windows.net/decisionservice.json\")\n", |
There was a problem hiding this comment.
Might want to use something with more than 3 data points
There was a problem hiding this comment.
checking w/ VW team
notebooks/features/vw/Vowpal Wabbit - Classification using SparkML Vector.ipynb
Show resolved
Hide resolved
notebooks/features/vw/Vowpal Wabbit - Classification using SparkML Vector.ipynb
Outdated
Show resolved
Hide resolved
| "from synapse.ml.train import ComputeModelStatistics\n", | ||
| "\n", | ||
| "metrics = ComputeModelStatistics(\n", | ||
| " evaluationMetric=\"classification\", labelCol=\"label\", scoredLabelsCol=\"prediction\"\n", |
There was a problem hiding this comment.
nit: multiline here would be prettier
There was a problem hiding this comment.
doesent seem to be committed
notebooks/features/vw/Vowpal Wabbit - Classification using VW-native Format.ipynb
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tests
some added.
Dependency changes
Updated to the latest VW binding (thanks @jackgerrits for pushing so hard)
AB#1890635