Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic version updates for github actions with dependabot #1608

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

iemejia
Copy link
Contributor

@iemejia iemejia commented Aug 10, 2022

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Add a dependabot file to update the versions of the Github Actions used for CI jobs

Briefly describe the changes included in this Pull Request.
This requires to create a dependabot.yml file and to enable dependabot in the settings of the repository

How is this patch tested?

I applied it in my fork and it proposed the correct updates (and a security alert).
https://github.com/iemejia/SynapseML/pulls

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

AB#1922685

@iemejia iemejia requested a review from mhamilton723 as a code owner August 10, 2022 15:35
@github-actions
Copy link

Hey @iemejia 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.
We appreciate your patience and contributions 💯!

@iemejia iemejia changed the title Auto update github actions with dependabot Automatic version updates for github actions with dependabot Aug 10, 2022
Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@mhamilton723 mhamilton723 merged commit 78e40cb into microsoft:master Aug 10, 2022
@iemejia iemejia deleted the dependabot branch August 10, 2022 19:39
@iemejia
Copy link
Contributor Author

iemejia commented Aug 11, 2022

We can add automatic dependency updates for other ecosystems (scala, .net, etc) but given how error-prone are the dependency updates of Spark and friends it is probably better to be conservative, but let me know if you want me try a PR for that.

@iemejia
Copy link
Contributor Author

iemejia commented Aug 11, 2022

Oups seems like sbt is not supported yet
dependabot/dependabot-core#352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants