Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VW adjust learning rate for boston data example #1853

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

eisber
Copy link
Collaborator

@eisber eisber commented Mar 2, 2023

What changes are proposed in this pull request?

Update learning rate. @jackgerrits I assume that the defaults maybe changed? Learning rate was 7 and I changed to 0.5 (did a small hyper parameter search).

How is this patch tested?

Compared RMSE

@eisber eisber requested a review from mhamilton723 as a code owner March 2, 2023 08:30
@eisber
Copy link
Collaborator Author

eisber commented Mar 2, 2023

/azp run

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Hey @eisber 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #1853 (646426b) into master (d64563f) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1853      +/-   ##
==========================================
- Coverage   86.86%   86.85%   -0.02%     
==========================================
  Files         299      299              
  Lines       15506    15506              
  Branches      784      784              
==========================================
- Hits        13470    13467       -3     
- Misses       2036     2039       +3     
Impacted Files Coverage Δ
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 75.00% <0.00%> (-7.36%) ⬇️
...gnitive/anomaly/MultivariateAnomalyDetection.scala 88.97% <0.00%> (+0.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eisber
Copy link
Collaborator Author

eisber commented Mar 2, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 66f30e3 into microsoft:master Mar 2, 2023
@jackgerrits
Copy link
Member

LGTM, sounds like a more reasonable learning rate. I doubt 7 has ever been default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants