Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove extraneous "Foo" type from Py codegen #1867

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

BrendanWalsh
Copy link
Collaborator

This type appears to be an artifact from testing/development and has no references in the source.

This type appears to be an artifact from testing/development and has no references in the source.
@github-actions
Copy link

Hey @BrendanWalsh 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 enabled auto-merge (squash) March 13, 2023 13:29
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Merging #1867 (21a2497) into master (dedcbda) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
- Coverage   86.86%   86.81%   -0.05%     
==========================================
  Files         299      299              
  Lines       15521    15521              
  Branches      793      793              
==========================================
- Hits        13482    13475       -7     
- Misses       2039     2046       +7     
Impacted Files Coverage Δ
...microsoft/azure/synapse/ml/codegen/PyCodegen.scala 91.48% <ø> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mhamilton723 mhamilton723 disabled auto-merge March 13, 2023 17:57
@mhamilton723 mhamilton723 merged commit 83f8260 into master Mar 13, 2023
@mhamilton723 mhamilton723 deleted the BrendanWalsh-foo branch March 13, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants