Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DML .setFitIntercept should be set to true in final stage linear model #1869

Closed
sarahshy opened this issue Mar 14, 2023 · 5 comments
Closed

DML .setFitIntercept should be set to true in final stage linear model #1869

sarahshy opened this issue Mar 14, 2023 · 5 comments
Assignees
@dylanw-oss
Labels
bug

Comments

@sarahshy
Copy link
Contributor

SynapseML/core/src/main/scala/com/microsoft/azure/synapse/ml/causal/DoubleMLEstimator.scala

Line 259 in 62c79d8

.setFitIntercept(false)

Currently .setFitIntercept is set to false, which will force the intercept to be 0. This should be changed to true as it may change the estimate for the slope in the residuals linear model.

@dylanw-oss
@github-actions
Copy link

Hey @sarahshy 👋!
Thank you so much for reporting the issue/feature request 🚨.
Someone from SynapseML Team will be looking to triage this issue soon.
We appreciate your patience.

@sarahshy sarahshy changed the title .setFitIntercept should be set to true in final stage linear model DML .setFitIntercept should be set to true in final stage linear model Mar 14, 2023
@dylanw-oss dylanw-oss self-assigned this Mar 14, 2023
@memoryz memoryz added the bug label Mar 15, 2023
dylanw-oss added a commit to dylanw-oss/SynapseML that referenced this issue Mar 16, 2023
@dylanw-oss
Fix bug microsoft#1869, DML .setFitIntercept should be set to true
bcbb648
@dylanw-oss dylanw-oss mentioned this issue Mar 16, 2023
Merged
mhamilton723 pushed a commit that referenced this issue Mar 20, 2023
@dylanw-oss
fix: fix bug #1869, DML .setFitIntercept should be set to true (#1876)
564d047 
* Fix bug #1869, DML .setFitIntercept should be set to true

* don't need to check integerType as it can work for both classification and regression mdoel

* fix type checking

* only support boolean for calssification model

* we should support 0/1 integert column with classification model

* add two test cases
@k-rush
Copy link
Contributor

k-rush commented Mar 20, 2023

@mhamilton723 and @dylanw-oss, I see this issue has been addressed in #1876. Do we have a new build of the library that @sarahshy can use?

@k-rush k-rush removed the triage label Mar 20, 2023
@dylanw-oss
Copy link
Contributor

yes, the master branch build should have the fix, "com.microsoft.azure:synapseml-core_2.12:0.11.0-19-87e1c786-SNAPSHOT"

@k-rush
Copy link
Contributor

k-rush commented Mar 24, 2023

@sarahshy can you try using this new build?

"com.microsoft.azure:synapseml-core_2.12:0.11.0-19-87e1c786-SNAPSHOT"

@dylanw-oss
Copy link
Contributor

we can close this issue on behalf of Sarah.

@github-actions github-actions bot reopened this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dylanw-oss dylanw-oss

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@memoryz @k-rush @sarahshy @dylanw-oss