This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Update mentions of internal/external modules to use namespaces/modules #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| Functions are the fundamental building block of any applications in JavaScript. | |||
| They're how you build up layers of abstraction, mimicking classes, information hiding, and modules. | |||
| In TypeScript, while there are classes and modules, function still play the key role in describing how to `do` things. | |||
| In TypeScript, while there are classes, namespaces, and modules, function still play the key role in describing how to *do* things. | |||
There was a problem hiding this comment.
This emphasis seems silly, but I'm willing to keep it.
| @@ -393,18 +409,18 @@ In some cases, you may want to only load a module under some conditions. | |||
| In TypeScript, we can use the pattern shown below to implement this and other advanced loading scenarios to directly invoke the module loaders without losing type safety. | |||
|
|
|||
| The compiler detects whether each module is used in the emitted JavaScript. | |||
| For modules that are only used as part of the type system, no require calls are emitted. | |||
| For modules that are only used as part of the type system, no `require` calls are emitted. | |||
There was a problem hiding this comment.
This wording is a little odd ('part of the type system'). I would say like "If a module identifier is only ever used in type annotations and never as an expression then no 'require' call is emitted for that module." Alternatively you could use our usual 'type position' terminology which is referenced a few lines down.
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Jun 2, 2015
Update mentions of internal/external modules to use namespaces/modules
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #36. Not sure if this is what you had in mind @danquirk but I'd definitely appreciate your feedback.
As usual, rich diff is best diff.