Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codefix for "Did you mean to include 'new'?" #26580

Closed
ghost opened this issue Aug 21, 2018 · 2 comments
Closed

Codefix for "Did you mean to include 'new'?" #26580

ghost opened this issue Aug 21, 2018 · 2 comments
Labels
Domain: Quick Fixes Editor-provided fixes, often called code actions. Experience Enhancement Noncontroversial enhancements Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript
Milestone
TypeScript 3.2.1

Comments

@ghost
Copy link

ghost commented Aug 21, 2018

Suggestion

Given this code:

class C {}
C();

The error message says Did you mean to include 'new'?. We should have code fix that adds 'new' in front of the call expression.
@ghost ghost added Suggestion An idea for TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. labels Aug 21, 2018
@RyanCavanaugh RyanCavanaugh added the Experience Enhancement Noncontroversial enhancements label Aug 21, 2018
@DanielRosenwasser DanielRosenwasser added Help Wanted You can do this Good First Issue Well scoped, documented and has the green light labels Sep 7, 2018
@DanielRosenwasser DanielRosenwasser added this to the Community milestone Sep 7, 2018
@iliashkolyar iliashkolyar mentioned this issue Sep 11, 2018
Merged
@LasaleFamine
Copy link

LasaleFamine commented Oct 1, 2018 •
edited
Loading

Hi there, I would like to help with this (maybe simple) task. Have you some hint for me to start working on this?

I'm just getting inside the source code, maybe I will find something meanwhile.

EDIT: Whoops! I didn't see the PR already opened. I will find another issue 😄

@DanielRosenwasser
Copy link
Member

No worries @LasaleFamine; thanks @iliashkolyar!

@DanielRosenwasser DanielRosenwasser added the Fixed A PR has been merged for this issue label Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: Quick Fixes Editor-provided fixes, often called code actions. Experience Enhancement Noncontroversial enhancements Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 3.2.1
Development

No branches or pull requests
3 participants
@DanielRosenwasser @RyanCavanaugh @LasaleFamine